diff options
author | Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> | 2017-08-02 12:06:35 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-08-16 20:43:21 (GMT) |
commit | 2db03a7fa0ddb671d2508325e1243bd46ab4c6dc (patch) | |
tree | d8fa91111f6633c9e17c41e9accd11a441715c58 /lib/ts_kmp.c | |
parent | a09ecc9345b6bf07812e55070328d7c0bdb2c498 (diff) | |
download | linux-2db03a7fa0ddb671d2508325e1243bd46ab4c6dc.tar.xz |
usb: gadget: udc: renesas_usb3: Fix usb_gadget_giveback_request() calling
commit aca5b9ebd096039657417c321a9252c696b359c2 upstream.
According to the gadget.h, a "complete" function will always be called
with interrupts disabled. However, sometimes usb3_request_done() function
is called with interrupts enabled. So, this function should be held
by spin_lock_irqsave() to disable interruption. Also, this driver has
to call spin_unlock() to avoid spinlock recursion by this driver before
calling usb_gadget_giveback_request().
Reported-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Tested-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/ts_kmp.c')
0 files changed, 0 insertions, 0 deletions