diff options
author | Miklos Szeredi <mszeredi@redhat.com> | 2016-07-01 12:56:07 (GMT) |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2016-07-01 14:24:18 (GMT) |
commit | 6343a2120862f7023006c8091ad95c1f16a32077 (patch) | |
tree | 544f8cf19d204a5df5d392faff3471fb715536dc /lib | |
parent | cb7d224f82e41d82518e7f9ea271d215d4d08e6e (diff) | |
download | linux-6343a2120862f7023006c8091ad95c1f16a32077.tar.xz |
locks: use file_inode()
(Another one for the f_path debacle.)
ltp fcntl33 testcase caused an Oops in selinux_file_send_sigiotask.
The reason is that generic_add_lease() used filp->f_path.dentry->inode
while all the others use file_inode(). This makes a difference for files
opened on overlayfs since the former will point to the overlay inode the
latter to the underlying inode.
So generic_add_lease() added the lease to the overlay inode and
generic_delete_lease() removed it from the underlying inode. When the file
was released the lease remained on the overlay inode's lock list, resulting
in use after free.
Reported-by: Eryu Guan <eguan@redhat.com>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Cc: <stable@vger.kernel.org>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions