summaryrefslogtreecommitdiff
path: root/mm/sparse.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2013-05-19 23:51:09 (GMT)
committerBen Myers <bpm@sgi.com>2013-05-20 19:25:50 (GMT)
commit28ca489c63e9aceed8801d2f82d731b3c9aa50f5 (patch)
treeef76b419c060971a615be94b00951a334c742067 /mm/sparse.c
parent49b137cbbcc836ef231866c137d24f42c42bb483 (diff)
downloadlinux-28ca489c63e9aceed8801d2f82d731b3c9aa50f5.tar.xz
xfs: fix rounding in xfs_free_file_space
The offset passed into xfs_free_file_space() needs to be rounded down to a certain size, but the rounding mask is built by a 32 bit variable. Hence the mask will always mask off the upper 32 bits of the offset and lead to incorrect writeback and invalidation ranges. This is not actually exposed as a bug because we writeback and invalidate from the rounded offset to the end of the file, and hence the offset we are actually punching a hole out of will always be covered by the code. This needs fixing, however, if we ever want to use exact ranges for writeback/invalidation here... Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Brian Foster <bfoster@redhat.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'mm/sparse.c')
0 files changed, 0 insertions, 0 deletions