diff options
| author | Eric Dumazet <edumazet@google.com> | 2016-06-27 15:38:50 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-06-29 09:25:11 (GMT) |
| commit | a3d2e9f8eb1487f4191ff08ce2d3d63702c65a90 (patch) | |
| tree | 6bd92ff1c7e9c968a795b73804f7cc2869f68659 /net/bridge/br_netlink.c | |
| parent | 96183182ad05d1ce31b9048921c12bf4ad621eaf (diff) | |
| download | linux-a3d2e9f8eb1487f4191ff08ce2d3d63702c65a90.tar.xz | |
tcp: do not send too big packets at retransmit time
Arjun reported a bug in TCP stack and bisected it to a recent commit.
In case where we process SACK, we can coalesce multiple skbs
into fat ones (tcp_shift_skb_data()), to lower write queue
overhead, because we do not expect to retransmit these packets.
However, SACK reneging can happen, forcing the sender to retransmit
all these packets. If skb->len is above 64KB, we then send buggy
IP packets that could hang TSO engine on cxgb4.
Neal suggested to use tcp_tso_autosize() instead of tp->gso_segs
so that we cook packets of optimal size vs TCP/pacing.
Thanks to Arjun for reporting the bug and running the tests !
Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Arjun V <arjun@chelsio.com>
Tested-by: Arjun V <arjun@chelsio.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_netlink.c')
0 files changed, 0 insertions, 0 deletions