diff options
| author | David S. Miller <davem@davemloft.net> | 2008-07-09 06:01:06 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-07-09 06:01:06 (GMT) |
| commit | 6fa9864b53f0680e432a2c431c2cf2055daa3a88 (patch) | |
| tree | 77e6964f84775d5f2ee152c249ee26aa326df4ac /net/core | |
| parent | 3e745dd6950d72d19e4cb30dc44307e8d6671864 (diff) | |
| download | linux-6fa9864b53f0680e432a2c431c2cf2055daa3a88.tar.xz | |
net: Clean up explicit ->tx_queue references in link watch.
First, we add a qdisc_tx_changing() helper which returns true if the
qdisc attachment is in transition.
Second, we remove an assertion warning which is of limited value and
is hard to express precisely in a multiqueue environment.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/link_watch.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/net/core/link_watch.c b/net/core/link_watch.c index 5021821..bf8f7af 100644 --- a/net/core/link_watch.c +++ b/net/core/link_watch.c @@ -77,12 +77,10 @@ static void rfc2863_policy(struct net_device *dev) } -static int linkwatch_urgent_event(struct net_device *dev) +static bool linkwatch_urgent_event(struct net_device *dev) { - struct netdev_queue *txq = &dev->tx_queue; - return netif_running(dev) && netif_carrier_ok(dev) && - txq->qdisc != txq->qdisc_sleeping; + qdisc_tx_changing(dev); } @@ -182,12 +180,9 @@ static void __linkwatch_run_queue(int urgent_only) rfc2863_policy(dev); if (dev->flags & IFF_UP) { - if (netif_carrier_ok(dev)) { - struct netdev_queue *txq = &dev->tx_queue; - - WARN_ON(txq->qdisc_sleeping == &noop_qdisc); + if (netif_carrier_ok(dev)) dev_activate(dev); - } else + else dev_deactivate(dev); netdev_state_change(dev); @@ -218,7 +213,7 @@ static void linkwatch_event(struct work_struct *dummy) void linkwatch_fire_event(struct net_device *dev) { - int urgent = linkwatch_urgent_event(dev); + bool urgent = linkwatch_urgent_event(dev); if (!test_and_set_bit(__LINK_STATE_LINKWATCH_PENDING, &dev->state)) { dev_hold(dev); |