diff options
| author | David S. Miller <davem@davemloft.net> | 2016-03-14 03:28:00 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-03-14 03:28:35 (GMT) |
| commit | fbd40ea0180a2d328c5adc61414dc8bab9335ce2 (patch) | |
| tree | f6a14f38046fe2dfa10e3295d1e6a059010097a1 /net/ipv4/devinet.c | |
| parent | f4fa6e6d883cd89fa5c240c1896a4dd329d1caa9 (diff) | |
| download | linux-fbd40ea0180a2d328c5adc61414dc8bab9335ce2.tar.xz | |
ipv4: Don't do expensive useless work during inetdev destroy.
When an inetdev is destroyed, every address assigned to the interface
is removed. And in this scenerio we do two pointless things which can
be very expensive if the number of assigned interfaces is large:
1) Address promotion. We are deleting all addresses, so there is no
point in doing this.
2) A full nf conntrack table purge for every address. We only need to
do this once, as is already caught by the existing
masq_dev_notifier so masq_inet_event() can skip this.
Reported-by: Solar Designer <solar@openwall.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Tested-by: Cyrill Gorcunov <gorcunov@openvz.org>
Diffstat (limited to 'net/ipv4/devinet.c')
| -rw-r--r-- | net/ipv4/devinet.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 65e76a4..e333bc8 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -334,6 +334,9 @@ static void __inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap, ASSERT_RTNL(); + if (in_dev->dead) + goto no_promotions; + /* 1. Deleting primary ifaddr forces deletion all secondaries * unless alias promotion is set **/ @@ -380,6 +383,7 @@ static void __inet_del_ifa(struct in_device *in_dev, struct in_ifaddr **ifap, fib_del_ifaddr(ifa, ifa1); } +no_promotions: /* 2. Unlink it */ *ifap = ifa1->ifa_next; |