diff options
author | stephen hemminger <stephen@networkplumber.org> | 2017-01-07 03:12:52 (GMT) |
---|---|---|
committer | Xie Xiaobo <xiaobo.xie@nxp.com> | 2017-07-14 10:08:26 (GMT) |
commit | 923c0029ee72bfd78a331f6d0df788a40a9178a1 (patch) | |
tree | afa4c5eda2144abb7b09654dcfae12d7cb7f6ace /net/mac80211 | |
parent | 95b8bbff6ecf0692747622af16d917a67313f8cc (diff) | |
download | linux-923c0029ee72bfd78a331f6d0df788a40a9178a1.tar.xz |
net: make ndo_get_stats64 a void function
The network device operation for reading statistics is only called
in one place, and it ignores the return value. Having a structure
return value is potentially confusing because some future driver could
incorrectly assume that the return value was used.
Fix all drivers with ndo_get_stats64 to have a void function.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mac80211')
-rw-r--r-- | net/mac80211/iface.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 8d7747e..95a7094 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1132,7 +1132,7 @@ static u16 ieee80211_netdev_select_queue(struct net_device *dev, return ieee80211_select_queue(IEEE80211_DEV_TO_SUB_IF(dev), skb); } -static struct rtnl_link_stats64 * +static void ieee80211_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) { int i; @@ -1157,8 +1157,6 @@ ieee80211_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) stats->rx_bytes += rx_bytes; stats->tx_bytes += tx_bytes; } - - return stats; } static const struct net_device_ops ieee80211_dataif_ops = { |