diff options
author | Hannes Frederic Sowa <hannes@stressinduktion.org> | 2015-01-23 11:01:26 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-01-27 01:28:27 (GMT) |
commit | df4d92549f23e1c037e83323aff58a21b3de7fe0 (patch) | |
tree | cb82536dd48281496b6652b628266cdcacffb91d /net/wireless | |
parent | 412d2907c41531b60c7ea1f38cfe1116daf2a229 (diff) | |
download | linux-df4d92549f23e1c037e83323aff58a21b3de7fe0.tar.xz |
ipv4: try to cache dst_entries which would cause a redirect
Not caching dst_entries which cause redirects could be exploited by hosts
on the same subnet, causing a severe DoS attack. This effect aggravated
since commit f88649721268999 ("ipv4: fix dst race in sk_dst_get()").
Lookups causing redirects will be allocated with DST_NOCACHE set which
will force dst_release to free them via RCU. Unfortunately waiting for
RCU grace period just takes too long, we can end up with >1M dst_entries
waiting to be released and the system will run OOM. rcuos threads cannot
catch up under high softirq load.
Attaching the flag to emit a redirect later on to the specific skb allows
us to cache those dst_entries thus reducing the pressure on allocation
and deallocation.
This issue was discovered by Marcelo Leitner.
Cc: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Marcelo Leitner <mleitner@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/wireless')
0 files changed, 0 insertions, 0 deletions