diff options
author | Florian Fainelli <f.fainelli@gmail.com> | 2015-05-15 19:38:01 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-05-18 03:40:24 (GMT) |
commit | 4ab7f9138147efbb3efab32a51a8da646769d740 (patch) | |
tree | 93e3c834d10338c3386a18a438f68853f7dc5bad /net | |
parent | 74b80e841b4da2f83d8f548f32cfe421fde85aca (diff) | |
download | linux-4ab7f9138147efbb3efab32a51a8da646769d740.tar.xz |
net: dsa: bcm_sf2: properly propagate carrier down state for MoCA
MoCA interfaces require the use of an user-space daemon (mocad) which
will typically use cmd->autoneg to force the link. This is causing other
network manager applications not to get proper carrier down
notifications because of the following sequence of events:
- link down interrupt is received, link is set to 0 by the interrupt
handler
- fixed_link update callback runs and updates the BMSR register
accordingly
- PHY library polls the PHY for link status, sees the link is down,
proceeds with reporting that
- mocad gets notified of the link state and call phy_ethtool_sset()
with cmd->autoneg set to the link status (0)
- phy_start_aneg() is called at the end of phy_ethtool_sset() and sets
the PHY state to PHY_FORCING
Just make sure we notify the interface carrier appropriately when we
detect that the link is down in our fixed_link update callback. This is
made local to the bcm_sf2 driver as the PHY library does the right thing
in any case. This is similar to the GENET change introduced in
54d7c01d3ed699cfc213115eaecfe1175cfaff8f ("net: bcmgenet: enable MoCA
link state change detection").
Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions