diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2009-03-25 16:24:34 (GMT) |
|---|---|---|
| committer | Patrick McHardy <kaber@trash.net> | 2009-03-25 16:24:34 (GMT) |
| commit | 78f3648601fdc7a8166748bbd6d0555a88efa24a (patch) | |
| tree | 6884aa56afe297f794b4bd926890a59eae6c259e /net | |
| parent | a9a9adfe2f99ddadfb574a098392a007970a1577 (diff) | |
| download | linux-78f3648601fdc7a8166748bbd6d0555a88efa24a.tar.xz | |
netfilter: nf_conntrack: use hlist_add_head_rcu() in nf_conntrack_set_hashsize()
Using hlist_add_head() in nf_conntrack_set_hashsize() is quite dangerous.
Without any barrier, one CPU could see a loop while doing its lookup.
Its true new table cannot be seen by another cpu, but previous table is still
readable.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_conntrack_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index 55befe5..54e983f 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter/nf_conntrack_core.c @@ -1121,7 +1121,7 @@ int nf_conntrack_set_hashsize(const char *val, struct kernel_param *kp) struct nf_conntrack_tuple_hash, hnode); hlist_del_rcu(&h->hnode); bucket = __hash_conntrack(&h->tuple, hashsize, rnd); - hlist_add_head(&h->hnode, &hash[bucket]); + hlist_add_head_rcu(&h->hnode, &hash[bucket]); } } old_size = nf_conntrack_htable_size; |