diff options
author | Nithin Sujir <nsujir@broadcom.com> | 2013-03-08 08:01:24 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-03-08 18:14:58 (GMT) |
commit | 84421b99cedc3443e76d2a594f3c815d5cb9a8e1 (patch) | |
tree | e0a6b178ea560ea57da344c3bdae8cf93179f0cc /net | |
parent | ddf64354af4a702ee0b85d0a285ba74c7278a460 (diff) | |
download | linux-84421b99cedc3443e76d2a594f3c815d5cb9a8e1.tar.xz |
tg3: Update link_up flag for phylib devices
Commit f4a46d1f46a8fece34edd2023e054072b02e110d introduced a bug where
the ifconfig stats would remain 0 for phylib devices. This is due to
tp->link_up flag never becoming true causing tg3_periodic_fetch_stats()
to return.
The link_up flag was being updated in tg3_test_and_report_link_chg()
after setting up the phy. This function however, is not called for
phylib devices since the driver does not do the phy setup.
This patch moves the link_up flag update into the common
tg3_link_report() function that gets called for phylib devices as well
for non phylib devices when the link state changes.
To avoid updating link_up twice, we replace tg3_carrier_...() calls that
are followed by tg3_link_report(), with netif_carrier_...(). We can then
remove the unused tg3_carrier_on() function.
CC: <stable@vger.kernel.org>
Reported-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions