summaryrefslogtreecommitdiff
path: root/samples
diff options
context:
space:
mode:
authorChris Rankin <rankincj@yahoo.com>2012-04-06 21:38:18 (GMT)
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-04-09 12:41:34 (GMT)
commit556a0442e08a8bc8541587a349cbf26ed14ec6de (patch)
treebfa92fdc8e06bcf3d20d759f18dae84574b92c9e /samples
parent7483d45f0aee3afc0646d185cabd4af9f6cab58c (diff)
downloadlinux-556a0442e08a8bc8541587a349cbf26ed14ec6de.tar.xz
[media] dvb_frontend: regression fix: userspace ABI broken for xine
The commit e399ce77e6e has broken the DVB ABI for xine: The problem is that xine is expecting every event after a successful FE_SET_FRONTEND ioctl to have a non-zero frequency parameter, regardless of whether the tuning process has LOCKed yet. What used to happen is that the events inherited the initial tuning parameters from the FE_SET_FRONTEND call. However, the fepriv->parameters_out struct is now not initialised until the status contains the FE_HAS_LOCK bit. You might argue that this behaviour is intentional, except that if an application other than xine uses the DVB adapter and manages to set the parameters_out.frequency field to something other than zero, then xine no longer has any problems until either the adapter is replugged or the kernel modules reloaded. This can only mean that the fepriv->parameters_out struct still contains the (stale) tuning information from the previous application. Signed-off-by: Chris Rankin <rankincj@yahoo.com> Cc: stable@kernel.org # for kernel version 3.3 Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions