summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2008-12-04 19:21:31 (GMT)
committerJ. Bruce Fields <bfields@citi.umich.edu>2009-01-06 16:53:52 (GMT)
commitc8c23c423dec49cb439697d3dc714e1500ff1610 (patch)
tree161035f51e31cce6d9f8dc104bad62a329496a77 /security
parent1e49323c4ab044d05bbc68cf13cadcbd4372468c (diff)
downloadlinux-c8c23c423dec49cb439697d3dc714e1500ff1610.tar.xz
NSM: Release nsmhandle in nlm_destroy_host
The nsm_handle's reference count is bumped in nlm_lookup_host(). It should be decremented in nlm_destroy_host() to make it easier to see the balance of these two operations. Move the nsm_release() call to fs/lockd/host.c. The h_nsmhandle pointer is set in nlm_lookup_host(), and never cleared. The nlm_destroy_host() function is never called for the same nlm_host twice, so h_nsmhandle won't ever be NULL when nsm_unmonitor() is called. All references to the nlm_host are gone before it is freed. We can skip making h_nsmhandle NULL just before the nlm_host is deallocated. It's also likely we can remove the h_nsmhandle NULL check in nlmsvc_is_client() as well, but we can do that later when rearchitect- ing the nlm_host cache. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions