summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2011-02-27 21:43:24 (GMT)
committerTheodore Ts'o <tytso@mit.edu>2011-02-27 21:43:24 (GMT)
commita54aa76108619e5d8290b49081c2aaaeff5be9a2 (patch)
treea3c436e29b5452f9c17bffc7bbc6b8f437c3255c /security
parent168fc0223c0e944957b1f31d88c2334fc904baf1 (diff)
downloadlinux-a54aa76108619e5d8290b49081c2aaaeff5be9a2.tar.xz
ext4: don't leave PageWriteback set after memory failure
In ext4_bio_write_page(), if the memory allocation for the struct ext4_io_page fails, it returns with the page's PageWriteback flag set. This will end up causing the page not to skip writeback in WB_SYNC_NONE mode, and in WB_SYNC_ALL mode (i.e., on a sync, fsync, or umount) the writeback daemon will get stuck forever on the wait_on_page_writeback() function in write_cache_pages_da(). Or, if journalling is enabled and the file gets deleted, it the journal thread can get stuck in journal_finish_inode_data_buffers() call to filemap_fdatawait(). Another place where things can get hung up is in truncate_inode_pages(), called out of ext4_evict_inode(). Fix this by not setting PageWriteback until after we have successfully allocated the struct ext4_io_page. Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions