summaryrefslogtreecommitdiff
path: root/sound/Makefile
diff options
context:
space:
mode:
authorAlexey Dobriyan <adobriyan@gmail.com>2008-04-13 11:48:43 (GMT)
committerMauro Carvalho Chehab <mchehab@infradead.org>2008-04-24 17:09:40 (GMT)
commit9faa2d75822e1950b3aacc8ccbdf0cdb595e47de (patch)
treeda40b056cfb87ccad6414f0dd2b37abbe019fe35 /sound/Makefile
parentb9bc07a006ae94d7b3dd5db873bcf10ceb749253 (diff)
downloadlinux-9faa2d75822e1950b3aacc8ccbdf0cdb595e47de.tar.xz
V4L/DVB (7580): Fix concurrent read from /proc/videocodecs
Observation one: ->write_proc and ->data assignments aren't needed. Removed. Observation two: codecs lists are unprotected. Patch doesn't fix this. Observation three: /proc/videocodecs printout is done to temporary _global_ buffer which is freed in between. Consequently, two users hitting this file can screwup each other. Steps to reproduce: modprobe videocodec while true; do cat /proc/videocodecs &>/dev/null; done & while true; do cat /proc/videocodecs &>/dev/null; done & The fix is switching to seq_files, this removes code, especially some line-length "logic". Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Acked-by: Jan Kara <jack@suse.cz> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'sound/Makefile')
0 files changed, 0 insertions, 0 deletions