diff options
| author | Jesper Juhl <juhl-lkml@dif.dk> | 2005-06-25 21:58:49 (GMT) |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-06-25 23:25:00 (GMT) |
| commit | 09417379be9b126e10ae7dcd7afc20b666146266 (patch) | |
| tree | 0236f4cb1afb4cf9a7f13b67e6ac639c55fa0440 /sound/oss/ad1848.c | |
| parent | 4ae6673e029d609da7ef4311440d6de501d6967a (diff) | |
| download | linux-09417379be9b126e10ae7dcd7afc20b666146266.tar.xz | |
[PATCH] remove redundant NULL checks before kfree() in sound/ and avoid casting pointers about to be kfree()'ed
Checking a pointer for NULL before calling kfree() on it is redundant,
kfree() deals with NULL pointers just fine.
This patch removes such checks from sound/
This patch also makes another, but closely related, change.
It avoids casting pointers about to be kfree()'ed.
Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'sound/oss/ad1848.c')
| -rw-r--r-- | sound/oss/ad1848.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/oss/ad1848.c b/sound/oss/ad1848.c index 4384dac..7c835ab 100644 --- a/sound/oss/ad1848.c +++ b/sound/oss/ad1848.c @@ -2178,8 +2178,7 @@ void ad1848_unload(int io_base, int irq, int dma_playback, int dma_capture, int if (devc != NULL) { - if(audio_devs[dev]->portc!=NULL) - kfree(audio_devs[dev]->portc); + kfree(audio_devs[dev]->portc); release_region(devc->base, 4); if (!share_dma) |