diff options
author | Krzysztof Opasiak <k.opasiak@samsung.com> | 2016-12-20 18:52:16 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-12 10:39:11 (GMT) |
commit | 2b95c939cb88c3182e9dd681d4cf40b70985b8a5 (patch) | |
tree | 65ff0b943ec3f2f7fe6bbcce4cbd7152e8404856 /sound | |
parent | 735daeec9e6062cad8aab412d0c04d26ae8e13e7 (diff) | |
download | linux-2b95c939cb88c3182e9dd681d4cf40b70985b8a5.tar.xz |
usb: gadget: composite: Test get_alt() presence instead of set_alt()
commit 7e4da3fcf7c9fe042f2f7cb7bf23861a899b4a8f upstream.
By convention (according to doc) if function does not provide
get_alt() callback composite framework should assume that it has only
altsetting 0 and should respond with error if host tries to set
other one.
After commit dd4dff8b035f ("USB: composite: Fix bug: should test
set_alt function pointer before use it")
we started checking set_alt() callback instead of get_alt().
This check is useless as we check if set_alt() is set inside
usb_add_function() and fail if it's NULL.
Let's fix this check and move comment about why we check the get
method instead of set a little bit closer to prevent future false
fixes.
Fixes: dd4dff8b035f ("USB: composite: Fix bug: should test set_alt function pointer before use it")
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
0 files changed, 0 insertions, 0 deletions