diff options
| author | Takashi Iwai <tiwai@suse.de> | 2016-11-29 21:28:40 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-01-12 10:39:19 (GMT) |
| commit | e7c72dccd7250c8379fef1cc2551c3c55009a4e4 (patch) | |
| tree | 4786d7e9ddff76189355315d1030624978adbf11 /sound | |
| parent | 2eb09ccfa45b4367a7f416936cf757b95063d015 (diff) | |
| download | linux-e7c72dccd7250c8379fef1cc2551c3c55009a4e4.tar.xz | |
ALSA: usb-audio: Fix bogus error return in snd_usb_create_stream()
commit 4763601a56f155ddf94ef35fc2c41504a2de15f5 upstream.
The function returns -EINVAL even if it builds the stream properly.
The bogus error code sneaked in during the code refactoring, but it
wasn't noticed until now since the returned error code itself is
ignored in anyway. Kill it here, but there is no behavior change by
this patch, obviously.
Fixes: e5779998bf8b ('ALSA: usb-audio: refactor code')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/usb/card.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/usb/card.c b/sound/usb/card.c index 2ddc034..f36cb06 100644 --- a/sound/usb/card.c +++ b/sound/usb/card.c @@ -206,7 +206,6 @@ static int snd_usb_create_stream(struct snd_usb_audio *chip, int ctrlif, int int if (! snd_usb_parse_audio_interface(chip, interface)) { usb_set_interface(dev, interface, 0); /* reset the current interface */ usb_driver_claim_interface(&usb_audio_driver, iface, (void *)-1L); - return -EINVAL; } return 0; |