summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2016-10-15 15:50:49 (GMT)
committerDavid S. Miller <davem@davemloft.net>2016-10-17 14:52:59 (GMT)
commit9a0b1e8ba4061778897b544afc898de2163382f7 (patch)
tree910a94c53d211ba3a5a17f6dc39fad9649becd65 /tools/testing
parenta04a480d4392ea6efd117be2de564117b2a009c0 (diff)
downloadlinux-9a0b1e8ba4061778897b544afc898de2163382f7.tar.xz
net: pktgen: remove rcu locking in pktgen_change_name()
After Jesper commit back in linux-3.18, we trigger a lockdep splat in proc_create_data() while allocating memory from pktgen_change_name(). This patch converts t->if_lock to a mutex, since it is now only used from control path, and adds proper locking to pktgen_change_name() 1) pktgen_thread_lock to protect the outer loop (iterating threads) 2) t->if_lock to protect the inner loop (iterating devices) Note that before Jesper patch, pktgen_change_name() was lacking proper protection, but lockdep was not able to detect the problem. Fixes: 8788370a1d4b ("pktgen: RCU-ify "if_list" to remove lock in next_to_run()") Reported-by: John Sperbeck <jsperbeck@google.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Jesper Dangaard Brouer <brouer@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions