summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorWaiman Long <Waiman.Long@hp.com>2014-08-06 23:05:36 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2014-08-07 01:01:16 (GMT)
commitf8303c2582b889351e261ff18c4d8eb197a77db2 (patch)
tree0002a48b72f0934294d8bb56d0cae6d3dd935838 /tools/testing
parent0de9d2ebe590f9203dac59d4b8e298c473764b92 (diff)
downloadlinux-f8303c2582b889351e261ff18c4d8eb197a77db2.tar.xz
mm, thp: move invariant bug check out of loop in __split_huge_page_map
In __split_huge_page_map(), the check for page_mapcount(page) is invariant within the for loop. Because of the fact that the macro is implemented using atomic_read(), the redundant check cannot be optimized away by the compiler leading to unnecessary read to the page structure. This patch moves the invariant bug check out of the loop so that it will be done only once. On a 3.16-rc1 based kernel, the execution time of a microbenchmark that broke up 1000 transparent huge pages using munmap() had an execution time of 38,245us and 38,548us with and without the patch respectively. The performance gain is about 1%. Signed-off-by: Waiman Long <Waiman.Long@hp.com> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Rik van Riel <riel@redhat.com> Cc: Scott J Norton <scott.norton@hp.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions