summaryrefslogtreecommitdiff
path: root/drivers/staging/wilc1000
AgeCommit message (Collapse)Author
2016-04-12cfg80211: remove enum ieee80211_bandJohannes Berg
This enum is already perfectly aliased to enum nl80211_band, and the only reason for it is that we get IEEE80211_NUM_BANDS out of it. There's no really good reason to not declare the number of bands in nl80211 though, so do that and remove the cfg80211 one. Signed-off-by: Johannes Berg <johannes.berg@intel.com>
2016-03-23staging: wilc1000: fix a couple of memory leaksColin Ian King
The ENOMEM error return paths are not free'ing allocated memory resulting in a memory leak of allocated structures. Perform the required kfree to fix the memory leaks. Issue discovered with static analysis using CoverityScan Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-23staging: wilc1000: fixed kernel panic when firmware is not startedLeo Kim
This patch fixed the problems caused by if firmware is not started. That is why, in nl80211 put current TX power in interface info. If firmware is not started, this function(get_tx_power) does not work. Signed-off-by: Leo Kim <leo.kim@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-12staging: wilc1000: Possible unnecessary 'out of memory' messageAnchal Jain
Remove unnnecessary debug message. Problem detected by checkpatch. Signed-off-by: Anchal Jain <anchalj109@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-12staging: wilc1000: use mutex instead of semaphore sem_cfg_valuesChaehyun Lim
This patch replaces struct semaphore sem_cfg_values with struct mutex cfg_values_lock. It is better to use mutex than semaphore. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: use switch statement instead of multiple if statementChaehyun Lim
It is more readable than multiple if-else statement. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove unnecessary commentsChaehyun Lim
This patch removes unnecessary comments because enum cfg_cmd_type shows each command type without it. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: add enum cfg_type_cmdChaehyun Lim
This patch adds a new enum cfg_type_cmd to change hard-coded command type. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: rename hardwareProductVersion in struct wilc_mac_cfgChaehyun Lim
This patch renames hardwareProductVersion to hw_product_version to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove commented codesChaehyun Lim
This patch removes commented codes in struct wilc_cfg_str. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: use TAG_PARAM_OFFSET defineChaehyun Lim
TAG_PARAM_OFFSET is defined at top of this file so that it is used to simplify codes. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: Remove a whitespace before parenthesisAnchal Jain
Remove a whitespace before parenthesis "(" Signed-off-by: Anchal Jain <anchalj109@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove typedef from enum tenuConnectStsChaehyun Lim
This patch removes typedef from enum tenuConnectSts and renames it to connect_status to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove unused defineChaehyun Lim
This patch removes INFINITE_SLEEP_TIME that is not used in the driver, so just remove it. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove typedef from sdio_cmd53_tChaehyun Lim
This patch removes typedef from struct sdio_cmd53_t and renames it to sdio_cmd53. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove unnecessary comment codesChaehyun Lim
This patch removes unnecessary comment code in struct sdio_cmd53_t. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-04staging: wilc1000: remove typedef from struct sdio_cmd52_tChaehyun Lim
This patch removes typedef from struct sdio_cmd52_t and renames it to sdio_cmd52. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: wilc_wlan: Remove wrapper functionAmitoj Kaur Chawla
Remove is_tcp_ack_filter() which only returns the value of boolean variable `enabled` by replacing the only call site with the variable `enabled` itself. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: wilc_wlan_if.h: remove unused functionsTony Cho
This patch removes the unused functions anymore related to the configuration of the bus interface clock speed. Signed-off-by: Tony Cho <tony.cho@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: Removed unused variablesBhaktipriya Shridhar
Variables pcgroup_encrypt_val,pccipher_group,pcwpa_version, hold different values at different stages of the execution of connect(), however they are not being used anywhere. Hence, the unused variables have been removed. This was done using Coccinelle. @@ type T; identifier i; constant c; @@ -T i; <... when != i -i = c; ...> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: Remove unnecessary 'else'Rehas Sachdeva
This patch removes the checkpatch.pl warning: else is not generally useful after a break or return Signed-off-by: Rehas Sachdeva <aquannie@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: remove code for HOST_IF_MSG_SET_MAC_ADDRESSAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: remove code for HOST_IF_MSG_Q_IDLEAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: remove code for HOST_IF_MSG_FLUSH_CONNECTAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: remove code for HOST_IF_GET_LINKSPEEDAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, the #define, and the link_speed var. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-02staging: wilc1000: remove code for HOST_IF_MSG_GET_CHNLAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, the #define, and the channel var. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: remove code for HOST_IF_MSG_DEL_ALL_RX_BA_SESSIONSAlison Schofield
The function that sent this message id was previously removed. Finish the cleanup by removing the call to the message handler, the message handler, and the #define. Signed-off-by: Alison Schofield <amsfield22@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename u16reason in disconnect_infoChaehyun Lim
This patch renames u16reason to reason to remove u16 prefix. There is no need to use prefix to show data type. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename struct tstrDisconnectNotifInfoChaehyun Lim
This patch renames struct tstrDisconnectNotifInfo to disconnect_info to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename u16ConnectStatus in struct connect_infoChaehyun Lim
This patch renames u16ConnectStatus to status to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename u16RespIEsLen in struct connect_infoChaehyun Lim
This patch renames u16RespIEsLen to resp_ies_len to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename pu8RespIEs in struct connect_infoChaehyun Lim
This patch renames pu8RespIEs to resp_ies to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename ReqIEsLen in struct connec_infoChaehyun Lim
This patch renames ReqIEsLen to req_ies_len to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename pu8ReqIEs in struct connect_infoChaehyun Lim
This patch renames pu8ReqIEs to req_ies to avoid camelcase. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename au8bssid in struct connect_infoChaehyun Lim
This patch renames au8bssid to bssid to remove au8 prefix in struct connect_info. There is no need to use prefix to show data type of this variable. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: rename struct tstrConnectInfoChaehyun Lim
This patch renames struct tstrConnectInfo to connect_info to avoid camelcase and removes typedef. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: Remove useless return variablesBhaktipriya Shridhar
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: wilc_wlan.c: remove multiple blank lineTony Cho
This patch removes the multiple blank line reported by checkpatch.pl. Signed-off-by: Tony Cho <tony.cho@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: wilc_wlan.c: remove unnecessary blank linesTony Cho
This patch removes unnecessary blank lines found by checkpatch.pl. Signed-off-by: Tony Cho <tony.cho@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: Revert "staging: wilc1000: remove spaces around '->'"Leo Kim
This reverts commit 6c2ab2398b88 ("staging: wilc1000: remove spaces around '->'"). It had applied from a incorrectly commit a1b56a4c5054 ("staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages"). Signed-off-by: Leo Kim <leo.kim@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: removes unnecessary retry 3 timesLeo Kim
This patch removes unnecessary retry 3 times and related variable. Actually the retry 3 times sentence, don't retry at all. Repeats conditions are that until read a chip-id and written a register. Signed-off-by: Leo Kim <leo.kim@atmel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_cfg_param: remove unnecessary whitespaceChaehyun Lim
This patch removes unnecessary whitespace before a quoted newline found by checkpatch WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_cfg_param: fix line over 80 charactersChaehyun Lim
This patch fixes line over 80 characters found by checkpatch WARNING: line over 80 characters Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_cfg_param: fix logical continuationsChaehyun Lim
This patch fixes logical continuations found by checkpatch CHECK: Logical continuations should be on the previous line Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_cfg_param: rename wid_cntChaehyun Lim
wid_cnt variable is used as indicating array index of struct wid_list. This patch renames wid_cnt to i that makes more readability. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_cfg_param: change data type of wid_cntChaehyun Lim
This patch changes data type of wid_cnt from u8 to int. This variable uses array index of struct wid_list so that it is better to use int type. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_cfg_param: remove wrapper struct cfg_param_attrChaehyun Lim
This struct just wrap struct cfg_param_val. There is no other member except struct cfg_param_val. This patch remove struct cfg_param_attr, then struct cfg_param_val is renamed to struct cfg_param_attr. Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-26staging: wilc1000: handle_set_mac_address: fix missing blank line after ↵Chaehyun Lim
declaration commit 31cc9885e7c7 ("staging: wilc1000: handle_set_mac_address: use kmemdup") introduces a new checkpatch warning, so this patch fixes it. WARNING: Missing a blank line after declarations FILE: drivers/staging/wilc1000/host_interface.c:430: Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-22staging: wilc1000: wilc_wfi_netdevice: Remove header filesAmitoj Kaur Chawla
Remove duplicate header files. Found using includecheck. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-02-22staging: wilc1000: Remove header fileAmitoj Kaur Chawla
Remove duplicate header file. Found using includecheck. Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>