diff options
| author | jinghua <jinghua@marvell.com> | 2016-09-16 13:07:54 (GMT) |
|---|---|---|
| committer | Heiko Schocher <hs@denx.de> | 2016-09-26 08:42:56 (GMT) |
| commit | 85f03f0ea8532498d0fbae0749c23ee85e181322 (patch) | |
| tree | 02eac1dea8d25c69ae5433cdc667d7ae9b12a0f5 | |
| parent | 9ad5a00712fd1a75b047eca76d9ebaa76609ca11 (diff) | |
| download | u-boot-85f03f0ea8532498d0fbae0749c23ee85e181322.tar.xz | |
i2c: mv_i2c.c: Validate read length in I2C command
The I2C bus will get stuck when reading 0 byte. So we add validation of
the read length in i2c_read(). This issue only occurs on read operation.
Signed-off-by: jinghua <jinghua@marvell.com>
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Nadav Haklai <nadavh@marvell.com>
Cc: Kostya Porotchkin <kostap@marvell.com>
Cc: Wilson Ding <dingwei@marvell.com>
Cc: Victor Gu <xigu@marvell.com>
Cc: Hua Jing <jinghua@marvell.com>
Cc: Terry Zhou <bjzhou@marvell.com>
Cc: Hanna Hawa <hannah@marvell.com>
Cc: Haim Boot <hayim@marvell.com>
Cc: Heiko Schocher <hs@denx.de>
| -rw-r--r-- | drivers/i2c/mv_i2c.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/i2c/mv_i2c.c b/drivers/i2c/mv_i2c.c index 291b2d7..7f52fa2 100644 --- a/drivers/i2c/mv_i2c.c +++ b/drivers/i2c/mv_i2c.c @@ -243,6 +243,11 @@ static int __i2c_read(struct mv_i2c *base, uchar chip, u8 *addr, int alen, debug("i2c_read(chip=0x%02x, addr=0x%02x, alen=0x%02x, " "len=0x%02x)\n", chip, *addr, alen, len); + if (len == 0) { + printf("reading zero byte is invalid\n"); + return -EINVAL; + } + i2c_reset(base); /* dummy chip address write */ |