diff options
author | Mats Kärrman <mats.karrman@tritech.se> | 2013-04-09 15:10:59 (GMT) |
---|---|---|
committer | Tom Rini <trini@ti.com> | 2013-04-10 14:31:02 (GMT) |
commit | fac150e83f403933e9ffc9d01f858c4a6313874e (patch) | |
tree | bb4ba2875fd12abdc370040eb79af5f1125407be /common/lcd.c | |
parent | 645b271a6039e79b368f027a5624dc0820441733 (diff) | |
download | u-boot-fac150e83f403933e9ffc9d01f858c4a6313874e.tar.xz |
powerpc/lib: fix unsafe register handling in wait_ticks
If watchdog is enabled, the arch/powerpc/lib/ticks.S::wait_ticks() function
calls the function specified by the WATCHDOG_RESET macro.
The wait_ticks function depends on the registers r0, r6 and r7 being
preserved however that is not guaranteed, e.g. if the reset function is a
C function this will probably overwrite r0 and cause an endless loop.
The following patch changes to using r14+r15 instead of r6+r7 (to resemble
what would have been generated by a C compiler) and saves all necessary
registers on the stack.
The patch has been tested on a custom MPC5125 based machine using the 512x
powerpc architecture.
Signed-off-by: Mats Karrman <mats.karrman@tritech.se>
Cc: Wolfgang Denk <wd@denx.de>
Acked-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Tested-by: Stefan Roese <sr@denx.de>
Diffstat (limited to 'common/lcd.c')
0 files changed, 0 insertions, 0 deletions