diff options
| author | Alexandru Gagniuc <alex.g@adaptrum.com> | 2017-04-04 17:42:31 (GMT) |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2017-04-08 13:26:55 (GMT) |
| commit | b09ece0836e0267b86f37defec267aa3806cb03a (patch) | |
| tree | 7d3a337c553b4e10f762ee2bf1de4db70bf816e5 /common/xyzModem.c | |
| parent | 306b236bc1e426ff58ea8ddba1c6ad10327de6ff (diff) | |
| download | u-boot-b09ece0836e0267b86f37defec267aa3806cb03a.tar.xz | |
common/xyzModem.c: Do not use hard-coded address for debug buffer
Under the plethora of #ifdefs, the xyzModem code hid this pearl:
static char *zm_out = (char *) 0x00380000;
This was only enabled when DEBUG is defined, so it's probably why it
went unnoticed for so long. No idea what platform had memory at that
exact location, but the this approach is extremely hacky.
Use a static buffer instead.
Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
Diffstat (limited to 'common/xyzModem.c')
| -rw-r--r-- | common/xyzModem.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/common/xyzModem.c b/common/xyzModem.c index 6ded958..a0c5dfe 100644 --- a/common/xyzModem.c +++ b/common/xyzModem.c @@ -176,16 +176,10 @@ parse_num (char *s, unsigned long *val, char **es, char *delim) /* * Note: this debug setup works by storing the strings in a fixed buffer */ -#define FINAL -#ifdef FINAL -static char *zm_out = (char *) 0x00380000; -static char *zm_out_start = (char *) 0x00380000; -#else -static char zm_buf[8192]; -static char *zm_out = zm_buf; -static char *zm_out_start = zm_buf; +static char zm_debug_buf[8192]; +static char *zm_out = zm_debug_buf; +static char *zm_out_start = zm_debug_buf; -#endif static int zm_dprintf (char *fmt, ...) { |