summaryrefslogtreecommitdiff
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorThomas Huth <huth@tuxfamily.org>2015-08-25 15:09:40 (GMT)
committerTom Rini <trini@konsulko.com>2015-10-24 17:50:30 (GMT)
commit310ae37edb3becedf5da904201f3439ea42ab12f (patch)
tree6d30471b538ed5718134a24220e6b7ccb20c2908 /drivers/hwmon
parentbff78567da51eee433e0e76a87edc5f0a03a0d8d (diff)
downloadu-boot-310ae37edb3becedf5da904201f3439ea42ab12f.tar.xz
Fix bad return value checks (detected with Coccinelle)
In the "Getting Started with Coccinelle - KVM edition" presentation that has been held by Julia Lawall at the KVM forum 2015 (see the slides at http://events.linuxfoundation.org/sites/events/files/slides/tutorial_kvm_0.pdf), she pointed out some bad return value checks in U-Boot that can be detected with Coccinelle by using the following config file: @@ identifier x,y; identifier f; statement S; @@ x = f(...); ( if (x < 0) S | if ( - y + x < 0) S ) This patch now fixes these issues. Signed-off-by: Thomas Huth <huth@tuxfamily.org>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/lm81.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/lm81.c b/drivers/hwmon/lm81.c
index c1fc42a..bcc8d32 100644
--- a/drivers/hwmon/lm81.c
+++ b/drivers/hwmon/lm81.c
@@ -90,7 +90,7 @@ int dtt_init_one(int sensor)
if (adr < 0)
return 1;
rev = dtt_read (sensor, DTT_REV);
- if (adr < 0)
+ if (rev < 0)
return 1;
debug ("DTT: Found LM81@%x Rev: %d\n", adr, rev);