diff options
| author | xypron.glpk@gmx.de <xypron.glpk@gmx.de> | 2017-07-30 18:27:16 (GMT) |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2017-08-13 19:17:27 (GMT) |
| commit | 6def7de37ba2aeb3d59c561b288537d8c3712c73 (patch) | |
| tree | fd37de32ae67577d6d7cbc30bff0934dc6cdd91e | |
| parent | 65e8ce29e4efc7f1716828ec845bd294a942e1ca (diff) | |
| download | u-boot-fsl-qoriq-6def7de37ba2aeb3d59c561b288537d8c3712c73.tar.xz | |
bcm281xx: clock: avoid possible NULL dereference
It does not make sense first to dereference c and then
to check if it is NULL.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
| -rw-r--r-- | arch/arm/cpu/armv7/bcm281xx/clk-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/arm/cpu/armv7/bcm281xx/clk-core.c b/arch/arm/cpu/armv7/bcm281xx/clk-core.c index cdc1264..b061c20 100644 --- a/arch/arm/cpu/armv7/bcm281xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm281xx/clk-core.c @@ -479,9 +479,9 @@ unsigned long clk_get_rate(struct clk *c) { unsigned long rate; - debug("%s: %s\n", __func__, c->name); if (!c || !c->ops || !c->ops->get_rate) return 0; + debug("%s: %s\n", __func__, c->name); rate = c->ops->get_rate(c); debug("%s: rate = %ld\n", __func__, rate); @@ -493,9 +493,9 @@ int clk_set_rate(struct clk *c, unsigned long rate) { int ret; - debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (!c || !c->ops || !c->ops->set_rate) return -EINVAL; + debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (c->use_cnt) return -EINVAL; |