diff options
| author | xypron.glpk@gmx.de <xypron.glpk@gmx.de> | 2017-04-15 13:23:49 (GMT) |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2017-04-18 14:29:24 (GMT) |
| commit | 0e0de24b07b8314ea0cc247a89b722c2230e4b0a (patch) | |
| tree | e93e1727b8bfd9f12eb14f3b497808316714bd49 /drivers/ddr | |
| parent | ea1e3f96c3666245b3651ab8022738763b97e6a8 (diff) | |
| download | u-boot-fsl-qoriq-0e0de24b07b8314ea0cc247a89b722c2230e4b0a.tar.xz | |
ddr: fsl: incorrect logical constraint in populate_memctl_options
(pdimm[0].data_width >= 32) || (pdimm[0].data_width <= 40)
is always true.
We should use && here.
The problem was indicated by cppcheck.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: York Sun <york.sun@nxp.com>
Diffstat (limited to 'drivers/ddr')
| -rw-r--r-- | drivers/ddr/fsl/options.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ddr/fsl/options.c b/drivers/ddr/fsl/options.c index d6a8fcb..cee97fe 100644 --- a/drivers/ddr/fsl/options.c +++ b/drivers/ddr/fsl/options.c @@ -916,7 +916,7 @@ unsigned int populate_memctl_options(const common_timing_params_t *common_dimm, if ((pdimm[0].data_width >= 64) && \ (pdimm[0].data_width <= 72)) popts->data_bus_width = 0; - else if ((pdimm[0].data_width >= 32) || \ + else if ((pdimm[0].data_width >= 32) && \ (pdimm[0].data_width <= 40)) popts->data_bus_width = 1; else { |