diff options
author | Przemyslaw Marczak <p.marczak@samsung.com> | 2015-05-13 11:38:26 (GMT) |
---|---|---|
committer | Simon Glass <sjg@chromium.org> | 2015-05-15 01:58:34 (GMT) |
commit | f415a3ec9dfafc887ddf34aee0c579fc948c5740 (patch) | |
tree | 3c864bede888f1352639e1d77e931ab1c7794fa9 /drivers/power/pmic/max77686.c | |
parent | ca2b933a382e823989c97a7d83c39825b8c22696 (diff) | |
download | u-boot-fsl-qoriq-f415a3ec9dfafc887ddf34aee0c579fc948c5740.tar.xz |
dm: pmic: code cleanup of PMIC uclass driver
The cleanup includes:
- pmic.h - fix mistakes in a few comments
- pmic operations: value 'reg_count' - redefine as function call
- fix function name: pmic_bind_childs() -> pmic_bind_children()
- pmic_bind_children: change the 'while' loop with the 'for'
- add implementation of pmic_reg_count() method
- pmic_bind_children() - update function call name
- Kconfig: add new line at the end of file
- Update MAX77686 driver code
Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
Acked-by: Simon Glass <sjg@chromium.org>
Tested on sandbox:
Tested-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/power/pmic/max77686.c')
-rw-r--r-- | drivers/power/pmic/max77686.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/power/pmic/max77686.c b/drivers/power/pmic/max77686.c index e9503e2..3523b4a 100644 --- a/drivers/power/pmic/max77686.c +++ b/drivers/power/pmic/max77686.c @@ -16,12 +16,17 @@ DECLARE_GLOBAL_DATA_PTR; -static const struct pmic_child_info pmic_childs_info[] = { +static const struct pmic_child_info pmic_children_info[] = { { .prefix = "ldo", .driver = MAX77686_LDO_DRIVER }, { .prefix = "buck", .driver = MAX77686_BUCK_DRIVER }, { }, }; +static int max77686_reg_count(struct udevice *dev) +{ + return MAX77686_NUM_OF_REGS; +} + static int max77686_write(struct udevice *dev, uint reg, const uint8_t *buff, int len) { @@ -47,7 +52,7 @@ static int max77686_bind(struct udevice *dev) { int regulators_node; const void *blob = gd->fdt_blob; - int childs; + int children; regulators_node = fdt_subnode_offset(blob, dev->of_offset, "voltage-regulators"); @@ -59,8 +64,8 @@ static int max77686_bind(struct udevice *dev) debug("%s: '%s' - found regulators subnode\n", __func__, dev->name); - childs = pmic_bind_childs(dev, regulators_node, pmic_childs_info); - if (!childs) + children = pmic_bind_children(dev, regulators_node, pmic_children_info); + if (!children) debug("%s: %s - no child found\n", __func__, dev->name); /* Always return success for this device */ @@ -68,7 +73,7 @@ static int max77686_bind(struct udevice *dev) } static struct dm_pmic_ops max77686_ops = { - .reg_count = MAX77686_NUM_OF_REGS, + .reg_count = max77686_reg_count, .read = max77686_read, .write = max77686_write, }; |