diff options
| author | Simon Glass <sjg@chromium.org> | 2015-10-18 21:55:31 (GMT) |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2015-10-21 13:46:50 (GMT) |
| commit | 9a4eb5977ad5dc2516e1219613258e30b10d27bd (patch) | |
| tree | 4dcf19a25f13ac70ea08c670bc4e1c70b0816af1 /drivers/rtc | |
| parent | b26eb88658b9fbb87c5bae22cede05de3124abb7 (diff) | |
| download | u-boot-fsl-qoriq-9a4eb5977ad5dc2516e1219613258e30b10d27bd.tar.xz | |
dm: rtc: Correct rtc_read32() return value
The current check is incorrect and will fail when any non-zero byte is read.
Fix it.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-uclass.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-uclass.c b/drivers/rtc/rtc-uclass.c index fe74c69..300e9b3 100644 --- a/drivers/rtc/rtc-uclass.c +++ b/drivers/rtc/rtc-uclass.c @@ -68,7 +68,7 @@ int rtc_read32(struct udevice *dev, unsigned int reg, u32 *valuep) for (i = 0; i < sizeof(value); i++) { ret = rtc_read8(dev, reg + i); - if (ret) + if (ret < 0) return ret; value |= ret << (i << 3); } |